Netcheck fails to find working IPv6 connection #2022
Comments
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 19, 2024
## Description We were incorrectly identifying globally routable IPv6 addresses as not routable. This make netcheck skip IPv6 addresses. ## Notes & open questions Closes #2022 The fix in the netcheck, test is curious, it fails on this PR fairly consistently yet it is really a flaky test introduced in combination with #2027. Now that we have IPv6 resolving properly we might get an IPv6 result. Since this test only has a single DerpUrl it only needs one result to complete. This could be an IPv4 OR an IPv6 result, we don't know which one will be faster. And if the other is slow enough then it won't be received. I think this behaviour is fine, we simply can't guarantee that both must have a result and the point of netcheck is to return something working quickly. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this issue
Feb 21, 2024
…computer#2030) ## Description We were incorrectly identifying globally routable IPv6 addresses as not routable. This make netcheck skip IPv6 addresses. ## Notes & open questions Closes n0-computer#2022 The fix in the netcheck, test is curious, it fails on this PR fairly consistently yet it is really a flaky test introduced in combination with n0-computer#2027. Now that we have IPv6 resolving properly we might get an IPv6 result. Since this test only has a single DerpUrl it only needs one result to complete. This could be an IPv4 OR an IPv6 result, we don't know which one will be faster. And if the other is slow enough then it won't be received. I think this behaviour is fine, we simply can't guarantee that both must have a result and the point of netcheck is to return something working quickly. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We saw a case of @ramfox having an IPv6 connection, default-net correctly knowing about the IPv6 addresses assigned and yet netcheck not finding that I can use IPv6. It never even runs the
StunIpv6probe. It should run an IPv6 probe and know there's IPv6 connectivity.The text was updated successfully, but these errors were encountered: