Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Process -> Service in status command, after help text #493

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Conversation

b5
Copy link
Member

@b5 b5 commented Nov 13, 2022

@b5 b5 added the c-cli label Nov 13, 2022
@b5 b5 self-assigned this Nov 13, 2022
@@ -14,8 +14,7 @@ use iroh_util::lock::{LockError, ProgramLock};

const SERVICE_START_TIMEOUT_SECONDS: u64 = 15;

/// start any of {iroh-gateway,iroh-store,iroh-p2p} that aren't currently
/// running.
/// start any given services that aren't currently running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase

@b5 b5 marked this pull request as ready for review November 14, 2022 19:16
@b5 b5 requested a review from ramfox November 14, 2022 19:16
Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@b5 b5 merged commit 804255c into main Nov 14, 2022
@b5 b5 deleted the b5/fix_463 branch November 14, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on iroh status show "Service" rather than "Process" as the table title
3 participants