Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to tempfile for temporary test directories #509

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

flub
Copy link
Contributor

@flub flub commented Nov 17, 2022

This removes the testdir crate for a temprorary testing directory and
uses the tempfile crate instead. It seems a transitive dependency for
testdir does not work on mac, which is kind of required for us.

This removes the testdir crate for a temprorary testing directory and
uses the tempfile crate instead.  It seems a transitive dependency for
testdir does not work on mac, which is kind of required for us.
@flub flub requested a review from ramfox November 17, 2022 16:08
@b5 b5 assigned flub Nov 17, 2022
Copy link
Contributor

@ramfox ramfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flub flub merged commit 89959cb into main Nov 17, 2022
@flub flub deleted the flub/no-testdir branch November 22, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants