add back iroh status -w feature using new rpc streams
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
commented
Dec 15, 2022
rklaehn
reviewed
Dec 15, 2022
|
Great work picking up the new stuff so quickly. |
ramfox
force-pushed
the
ramfox/health
branch
from
944ef06 to
5cbbca7
Compare
ramfox
force-pushed
the
ramfox/health
branch
from
92506f7 to
9901f98
Compare
|
@ramfox you have merge conflicts |
print version and remove "number" from `iroh status` output
write `HEALTH_POLL_WAIT` const in `iroh-rpc-client` and import from there
ramfox
force-pushed
the
ramfox/health
branch
from
01412e1 to
7f512d2
Compare
dignifiedquire
approved these changes
Dec 19, 2022
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Dec 28, 2022
) - add back `iroh status -w` feature using new rpc streams - add a `HEALTH_POLL_WAIT` constant for how long to wait between health check attempts - add a `VERSION` constant in each of `iroh-p2p`, `iroh-gateway`, `iroh-store` - rename `ServiceStatus` to `StatusType` - remove unused `StatusType` variants - rename `StatusRow` to `ServiceStatus` - rename `StatusTable` to `ClientStatus` - add a `ServiceType` enum with `P2p`, `Gateway`, and `Store` options - add `version` field to `ServiceStatus`, remove `number` field - adjust cli output to show the version & not show the "number"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes n0-computer/beetle#50