feat: html error handling #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
commented
Dec 20, 2022
| .await | ||
| .map_err(|e| GatewayError::new(StatusCode::INTERNAL_SERVER_ERROR, &e))?; | ||
| // TODO: handle 404 or error | ||
| let path_metadata = match state.client.retrieve_path_metadata(path.clone()).await { |
There was a problem hiding this comment.
@b5 this is the crucial bit - the earliest moment we ping store/p2p. I've updated error responses from fetch_gateway and fetch_bitswap so that it now catches them and returns a more sane response (failed to find {cid} || offline).
We should do similar for fetch_store to make it less jarring to the end users.
| let path_metadata = match state.client.retrieve_path_metadata(path.clone()).await { | ||
| Ok(metadata) => metadata, | ||
| Err(e) => { | ||
| if e == "offline" { |
dignifiedquire
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes n0-computer/beetle#253