fix NetBsd and FreeBsd #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
commented
May 21, 2024
•
dignifiedquire
commented
- compiles & passes tests on FreeBSD
- compiles & passes tests on NetBSD
- compiles & passes tests on OpenBSD
15 tasks
netbsd does not like getting unknown control messages. also does not like having a valid pointer if there are no control messages.
|
Just tested this on all 3 *BSDs and is fine. CI says it's still fine on linux & mac (and windows). So I think this can be merged. |
flub
approved these changes
May 24, 2024
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
May 24, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
May 24, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
rklaehn
pushed a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Oct 22, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
rklaehn
pushed a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Oct 22, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
matheus23
pushed a commit
to n0-computer/iroh-doctor
that referenced
this pull request
Oct 22, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
matheus23
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Nov 14, 2024
Adds support for `iroh` on `NetBSD`, `FreeBSD` and `OpenBSD`. ## Status - NetBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - FreeBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted - OpenBsd - [x] Compiles - [ ] Tests passing - [ ] Iroh: mostly passing, failures are only due to shellrow/netdev#69 - [x] Quinn - [x] Implementation adapted ## Caveats - Build only in CI for now ## Related Issues - shellrow/netdev#69 - n0-computer/quinn#9 ## References - https://github.com/freebsd/freebsd-ports/blob/78ad38f04f51/games/jumpy/files/patch-iroh - rust-lang/libc#3711 Closes #2306 --------- Co-authored-by: Floris Bruynooghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.