-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(response-cache): add response-cache-upstash #1404
base: main
Are you sure you want to change the base?
Conversation
@chronark We will delay dropping Node.js 12 support until The Yoga v3 launch (dotansimha/graphql-yoga#1358). Is there an alternative (older) version of |
Hmm, v1.3.0 or older might still work. But I'm not 100% sure. |
|
@chronark is attempting to deploy a commit to the The Guild Team on Vercel. A member of the Team first needs to authorize it. |
@chronark hey, we dropped Node 12 support by now - do you mind rebasing this PR? |
@n1ru4l I'll put it on my todo list for this or next week |
Hey @chronark, that's a neat plugin. Could you please rebase this PR? |
Can't really get the tests to pass right now and I'm not sure why |
a23dec1
to
3ac13be
Compare
Add redis cache using stateless HTTP connections instead of TCP with Upstash Redis.
Description
This is basically a copy of response-cache-redis where I changed a few details to make it work with
@upstash/redis
http client.Implements #1218
Type of change
How Has This Been Tested?
UPSTASH_REDIS_REST_URL=".." UPSTASH_REDIS_REST_TOKEN=".." yarn test
Test Environment:
Checklist:
Further comments
I haven't figured out why the tests are not passing yet, to me it seems unrelated to the implementation but I will take another look this week. It writes and reads from the cache but for some reason doesn't use the cache sometimes.