(refactor) Refactored result handler function to named function

To reduce nesting.
nDmitry · Apr 10, 2019 · afc581c · afc581c
1 parent 567a206
commit afc581c
Showing 1 changed file with 41 additions and 38 deletions.
diff --git a/tasks/postcss.js b/tasks/postcss.js
@@ -72,6 +72,45 @@ module.exports = function(grunt) {
         });
     }
 
+    function writeResult(tally, input, dest, result) {
+        var warnings = result.warnings();
+
+        tally.issues += warnings.length;
+
+        warnings.forEach(function(msg) {
+            grunt.log.error(msg.toString());
+        });
+
+        if (options.writeDest) {
+            grunt.file.write(dest, result.css);
+            log('File ' + chalk.cyan(dest) + ' created.');
+        }
+
+        tally.sheets += 1;
+
+        if (result.map) {
+            var mapDest = dest + '.map';
+
+            if (typeof options.map.annotation === 'string') {
+                mapDest = getSourcemapPath(dest);
+            }
+
+            grunt.file.write(mapDest, result.map.toString());
+            log('File ' + chalk.cyan(dest + '.map') + ' created (source map).');
+
+            tally.maps += 1;
+        }
+
+        if (options.diff) {
+            var diffPath = (typeof options.diff === 'string') ? options.diff : dest + '.diff';
+
+            grunt.file.write(diffPath, diff.createPatch(dest, input, result.css));
+            log('File ' + chalk.cyan(diffPath) + ' created (diff).');
+
+            tally.diffs += 1;
+        }
+    }
+
     /**
      * @param {string} msg Log message
      */
@@ -131,44 +170,8 @@ module.exports = function(grunt) {
                 var dest = f.dest || filepath;
                 var input = grunt.file.read(filepath);
 
-                return process(input, filepath, dest).then(function(result) {
-                    var warnings = result.warnings();
-
-                    tally.issues += warnings.length;
-
-                    warnings.forEach(function(msg) {
-                        grunt.log.error(msg.toString());
-                    });
-
-                    if (options.writeDest) {
-                        grunt.file.write(dest, result.css);
-                        log('File ' + chalk.cyan(dest) + ' created.');
-                    }
-
-                    tally.sheets += 1;
-
-                    if (result.map) {
-                        var mapDest = dest + '.map';
-
-                        if (typeof options.map.annotation === 'string') {
-                            mapDest = getSourcemapPath(dest);
-                        }
-
-                        grunt.file.write(mapDest, result.map.toString());
-                        log('File ' + chalk.cyan(dest + '.map') + ' created (source map).');
-
-                        tally.maps += 1;
-                    }
-
-                    if (options.diff) {
-                        var diffPath = (typeof options.diff === 'string') ? options.diff : dest + '.diff';
-
-                        grunt.file.write(diffPath, diff.createPatch(dest, input, result.css));
-                        log('File ' + chalk.cyan(diffPath) + ' created (diff).');
-
-                        tally.diffs += 1;
-                    }
-                });
+                return process(input, filepath, dest)
+                    .then(writeResult.bind(null, tally, input, dest));
             }));
         });