Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelShowCommand's parent class was changed in Laravel 11.33.0 #1989

Closed
cosmastech opened this issue Nov 20, 2024 · 1 comment · Fixed by #1990
Closed

ModelShowCommand's parent class was changed in Laravel 11.33.0 #1989

cosmastech opened this issue Nov 20, 2024 · 1 comment · Fixed by #1990
Labels

Comments

@cosmastech
Copy link

Versions:

  • laravel-modules Version: #.#.#
  • Laravel Version: 11.33.0
  • PHP Version: #.#.#

Description:

I introduced a change in this patch that I believe will break functionality for the ModelShowCommand, as it no longer has a qualifyModel() method.

I believe to fix this, we'll want to override the handle() method on the extended class and have it call qualifyModel, then pass that to ModelInspector, and finally pass the result to display().

I'm happy to work on this, though I'm not sure how soon I'll have time to work on it.

Steps To Reproduce:

@alissn
Copy link
Contributor

alissn commented Nov 21, 2024

Hi, @cosmastech

Thank you for reporting this! The issue will be fixed in pull request #1990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants