-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Extract ShowModelCommand
functionality to separate class
#53541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
cosmastech
force-pushed
the
extract-show-model
branch
from
November 16, 2024 22:55
2346c93
to
b9d3ec2
Compare
osbre
reviewed
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ShowModelCommand provides incredibly valuable information. It seems like third-party packages would be able to benefit from a unified way to retrieve model data. For instance, the laravel-ide-helper package has very similar logic. Larastan (which I don't assume this would replace, but pointing it out). Laravel Blueprint does a lot of this sort of parsing as well.
My thought is that this could be useful for a package that generates DTOs for models, thinking in terms of the idea of creating frozen models.
This also adds a fairly simple test for the console command output which previously was untested.
It would be nice if this command also returns the Model's
$builder
class and$collectionClass
. There could also be a number of docblock generics added to arrays in these functions. I figured this was already a pretty large PR, so that could follow up (whether this is accepted or not).Example Output