compatibility with vite #1455
compatibility with vite #1455
Conversation
|
this looks like it checks out. whats the plan to merge? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This merge has not taken any effect as well as NOT WORKING - SOLUTION DOES NOT TAKE EFFECT ON NEWLY CREATED PROJECT |
|
I'll look into it tonight and update before 10pm est. |
| {{-- Laravel Mix - CSS File --}} | ||
| {{-- <link rel="stylesheet" href="{{ mix('css/$LOWER_NAME$.css') }}"> --}} | ||
| {{-- Laravel Vite - CSS File --}} | ||
| {{-- {{ module_vite('build-$LOWER_NAME$', 'Resources/assets/sass/app.scss') }} --}} |
There was a problem hiding this comment.
I don't think you need the {{ inside the {{ same for the closing ones
| {{-- Laravel Mix - JS File --}} | ||
| {{-- <script src="{{ mix('js/$LOWER_NAME$.js') }}"></script> --}} | ||
| {{-- Laravel Vite - JS File --}} | ||
| {{-- {{ module_vite('build-$LOWER_NAME$', 'Resources/assets/js/app.js') }} --}} |
src/Commands/stubs/vite.stub
Outdated
| dotenvExpand(require('dotenv').config({ path: '../../.env'/*, debug: true*/})); | ||
|
|
||
| import { defineConfig } from 'vite'; | ||
| //import laravel from 'laravel-vite-plugin'; |
There was a problem hiding this comment.
the commented-out line, should it be active?
src/helpers.php
Outdated
| /** | ||
| * support for vite | ||
| */ | ||
| function module_vite($module, $asset): \Illuminate\Foundation\Vite |
There was a problem hiding this comment.
vite has already been imported, you should be able to use : Vite here.
|
I think it is ready |
Can't wait to try those. |
|
Any plans to get this merged? |
|
@wikigods can u show me demo how to use it? where should i run |
Support for vite
Today looking for a solution to use vite in the modules I found a temporary solution, I am open to suggestions for a better implementation in code. (Sorry my english is not very good)
attached images of the result I obtained