Add basic tools to Dockerfile #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bind-tools and ca-certificates to Docker Image
Added glider user and group to final image. Support for running Glider container as non-root user. Build image is now pinned to Golang 1.16 to avoid future issues when 1.17 is released.
|
@nadoo Let me know your thoughts on this. We are using a similar setup for our images and it has been working great with HTTP, SOCKS5 and TCP proxies. |
|
Hi @gaby , thanks for your PR! |
|
@nadoo i just noticed that line 19 is missing a backslash! |
Merged
|
Hi @gaby , glider v0.16.0 will be released when Go1.18 is out(soon), and the docker image will keep simple and small so the bind-tools will not be installed anymore. You can use glider image as a base image and create your own. Thanks for your help to make glider better, and I'm sorry for the inconvenience here. |
|
@nadoo No worries, it should still work for us. :-) Thanks for letting me know! Looking forward to v0.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shadowpackage to create a user/group for glider.glideruser and the/appis now owned by glider.