Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automating Password Entry #5

Closed
nakabonne opened this issue Nov 29, 2020 · 0 comments · Fixed by #12
Closed

Automating Password Entry #5

nakabonne opened this issue Nov 29, 2020 · 0 comments · Fixed by #12
Labels
enhancement New feature or request

Comments

@nakabonne
Copy link
Owner

It's a bit of a hassle to set the password every time; hence it would be nice to set it in an environment variable beforehand.

PBGOPY_PASSWORD_FILE=/home/foo/.config/pbgopy/pass.txt
@nakabonne nakabonne added the enhancement New feature or request label Nov 29, 2020
keyslapperdev pushed a commit to keyslapperdev/pbgopy that referenced this issue Dec 2, 2020
@awilcots
Issue nakabonne#5 - Automating Password Entry
8e0c51a 
In commands/copy.go
  Created new function getPasswordFromEnv to work as a fallback
   password if the -p flag is not set. Important to note, the -p
   flag takes priority over the env var, as it should.
  Updated logic to check password length before using it to encrypt

In commands/env.go
  Added new env const:
   const pbgopyPasswordFileEnv = "PBGOPY_PASSWORD_FILE"

In commands/paste.go
  Updated logic to check password length before using it to decrypt
@nakabonne nakabonne mentioned this issue Dec 5, 2020
Merged
keyslapperdev added a commit to keyslapperdev/pbgopy that referenced this issue Dec 7, 2020
@keyslapperdev
Issue nakabonne#5 - Addressed CR comments
32ef963 
In commands/copy.go
  Updated variable name 'fileLoc to filepath'
  Updated comparison from pass len to pass value

In commands/paste.go
  Updated comparison from pass len to pass value
@keyslapperdev keyslapperdev mentioned this issue Dec 7, 2020
Open
nakabonne added a commit that referenced this issue Dec 13, 2020
@nakabonne
Merge pull request #12 from name-schema/automating-password-entry-iss…
5652c16 
…ue-5

Issue #5 - Automating Password Entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5 - Automating Password Entry keyslapperdev/pbgopy
1 participant
@nakabonne