Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithRetention to automatically remove expired data #22

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

nakabonne
Copy link
Owner

Ref #18

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #22 (c6e8159) into main (2fd043f) will decrease coverage by 0.75%.
The diff coverage is 48.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   66.05%   65.31%   -0.74%     
==========================================
  Files          19       19              
  Lines         913      954      +41     
==========================================
+ Hits          603      623      +20     
- Misses        218      234      +16     
- Partials       92       97       +5     
Impacted Files Coverage Δ
fake_partition.go 25.00% <0.00%> (-3.57%) ⬇️
partition_list.go 82.83% <0.00%> (ø)
disk_partition.go 53.13% <33.34%> (-3.23%) ⬇️
storage.go 55.90% <55.89%> (-0.38%) ⬇️
memory_partition.go 78.04% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd043f...c6e8159. Read the comment docs.

@nakabonne nakabonne force-pushed the add-retention branch 3 times, most recently from 41bb6da to 8d86c20 Compare July 20, 2021 06:47
@nakabonne nakabonne marked this pull request as ready for review July 20, 2021 09:44
@nakabonne nakabonne merged commit f651d67 into main Jul 20, 2021
@nakabonne nakabonne deleted the add-retention branch July 20, 2021 09:44
@github-actions github-actions bot mentioned this pull request Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants