Export 'json_map()' type, remove ifdef(TEST) logic #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Export `json_map()` from jsn module, consistent with other JSON object format exports. * Remove `-ifdef(TEST)` logic for compiling with `export_all`; just do this in the `test` profile for succinctness. * Don't wrap `jsn_tests` in `-ifdef(TEST)` check; it's already isolated from `src` directory and does not need this extra layer of logic.
|
@mrallen1 wow, thanks for the lightning review! |
|
I can only doomscroll twitter for so long ;) |
va17
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_map()from jsn module, consistent with other JSON object format exports.-ifdef(TEST)logic for compiling withexport_all; just do this in thetestprofile for succinctness.jsn_testsin-ifdef(TEST)check; it's already isolated fromsrcdirectory and does not need this extra layer of logic.