Switch compression package (3x faster) #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `github.com/klauspost/compress` package for compression. Benchmarks did not actually compress since the header was carried over between calls. Before/after with fix in place. ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta BenchmarkSoleGin_SmallPayload-12 279 284 +1.79% BenchmarkGinWithDefaultHandler_SmallPayload-12 653 662 +1.38% BenchmarkSoleGin_BigPayload-12 271 284 +4.80% BenchmarkGinWithDefaultHandler_BigPayload-12 83649 25616 -69.38% ``` I believe the last benchmark is the only one actually to be compressing, correct? I didn't go out of my way to clean up the benchmark since the difference is rather obvious. The compression ratio is likely a bit less, but among many other changes the default settings have been tweaked to give the most reasonable speed/compression tradeoff.
My bad, thanks for fix that.
Yes, it is.
I will clean it up. 🤣
Generally speaking, is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
github.com/klauspost/compresspackage for compression.Benchmarks did not actually compress since the header was carried over between calls.
Before/after are both with the benchmark fix in place.
I believe the last benchmark is the only one actually to be compressing, correct?
I didn't go out of my way to clean up the benchmark since the difference is rather obvious.
The compression ratio is likely a bit less, but among many other changes the default settings have been tweaked to give the most reasonable speed/compression tradeoff.