-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary derivatives units and exact #1726
base: master
Are you sure you want to change the base?
Conversation
when deriving with respect to parameters with unit "deg" now returns correct units
This reverts commit 7079f00.
in BT and DD models. And adding exact derivatives to BT model.
Added a fix for the units that caused 3 of the errors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
- Coverage 69.06% 68.97% -0.09%
==========================================
Files 105 105
Lines 24700 24768 +68
Branches 4409 4414 +5
==========================================
+ Hits 17058 17084 +26
- Misses 6534 6576 +42
Partials 1108 1108 ☔ View full report in Codecov by Sentry. |
Hi, @DotanGazith . It looks like the black test is failing just on a single file. I don't know exactly how you have things set up locally but this should be easy to fix in general. |
More broadly, do you want to expose your exact BT model to the user? I think you could do that (make a wrapper class in |
Fixed the references in ELL1 model (references 1&2 were flipped)
Fixed the units of binary delay derivatives with respect to "angle" parameters (omega\E). Specifically in BT, DD models.
Added an exact derivative class for BT model. I kept it in a separate class to not clash with performance decisions that might drive the approximate derivative implemented.