Set default values of constants in white_noise_block #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the
white_noise_block
function, ifvary=False
theefac
,equad
andecorr
values are set asConstant
parameters without a given value for that constant. This means that the constant value will default toNone
. The docstring suggests that the constant values can be set later, but in a function such asmodel_singlepsr_noise
, ifwhite_vary=False
these constants don't get set and subsequent likelihood calls on the returnedpta
object fail due to the constants returningNone
.This PR attempts to fix this by setting some default values for the constants. In this case a value of
1.0
forefac
and-inf
for bothequad
andecorr
. This (assuming I understand things correctly!) would mean that the likelihood just uses the TOA errors as given as the standard deviations in the likelihood calculation (without any scaling, additional component, or correlation).See also nanograv/enterprise#379.