Merge pull request #1437 from narmi/a11y/NDS-701-tooltip-button-label

fix(Tooltip): improve a11y on trigger element
narmi · Dec 4, 2024 · c201415 · c201415
2 parents 6afb02e + 8045dd2
commit c201415
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Tooltip/index.js b/src/Tooltip/index.js
@@ -60,9 +60,11 @@ const Tooltip = ({
         onBlur={closePopover}
         onMouseEnter={openPopover}
         onMouseLeave={closePopover}
-        role="button"
+        // Giving this element a "button" role is misleading in practice.
+        // eslint-disable-next-line jsx-a11y/no-noninteractive-tabindex
         tabIndex="0"
         data-testid="nds-tooltip-trigger"
+        aria-expanded={open}
       >
         {children}
       </div>
@@ -81,7 +83,7 @@ const Tooltip = ({
               <Arrow {...arrowProps} />
             </div>
           )}
-        </>
+        </>,
       )}
     </>
   );