Refactor entity services to receive the request #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattschoch
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Refactor entity services to receive the request * Fix authz admin E2E test
wcalderipe
pushed a commit
that referenced
this pull request
Feb 5, 2025
* removed operations, scope sync can partially succeed * refactor bitgo and fireblocks * tests fixed for new interface * removed unused services imports * adding logs to the wallet bulkUpsert method * networkMap is a map, addressed namings, used constants instead of numbers * namings, complete function handles partial success for scoped sync service * lock sync when there's already an in progresss sync for this connection * Trying larger runner * fixed the network caching, and the lock on scope sync * Revert "Trying larger runner" This reverts commit bda1bb6b3154ae3f71740bbbcf7d0aca263649dc. * raw account errors are more precise * fireblocks raw accounts building use external network id * fixed reads for upserts outside of tx scope * exists take the status as a parameter * removed unused function * fixed fireblocks scoped sync mock server declaration --------- Co-authored-by: Matt Schoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor will allow us to do further validations on the request like signature verifications.