Skip to content

Commit

Permalink
merge new logger name
Browse files Browse the repository at this point in the history
  • Loading branch information
crsmith committed Aug 30, 2024
1 parent ea1cd9c commit baebba1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Drv/Ip/SocketComponentHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ SocketIpStatus SocketComponentHelper::reconnect() {
// Open a network connection if it has not already been open
if ((not this->isOpened()) and
((status = this->open()) != SOCK_SUCCESS)) {

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.
Fw::Logger::logMsg(
Fw::Logger::log(
"[WARNING] Failed to open port with status %d and errno %d\n",
static_cast<POINTER_CAST>(status),

Check failure

Code scanning / CodeQL

Wrong type of arguments to formatting function High

This format specifier for type 'int' does not match the argument type 'unsigned long'.
static_cast<POINTER_CAST>(errno));
Expand Down Expand Up @@ -180,7 +180,7 @@ void SocketComponentHelper::readTask(void* pointer) {
U32 size = buffer.getSize();
self->recv(data, size);

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function
recv
is not checked.
if ((status != SOCK_SUCCESS) && (status != SOCK_INTERRUPTED_TRY_AGAIN)) {
Fw::Logger::logMsg("[WARNING] Failed to recv from port with status %d and errno %d\n",
Fw::Logger::log("[WARNING] Failed to recv from port with status %d and errno %d\n",
static_cast<POINTER_CAST>(status),

Check failure

Code scanning / CodeQL

Wrong type of arguments to formatting function High

This format specifier for type 'int' does not match the argument type 'unsigned long'.
static_cast<POINTER_CAST>(errno));
self->close();
Expand Down

0 comments on commit baebba1

Please sign in to comment.