Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Os::Log into CMake Selection #2723

Closed
10 tasks done
LeStarch opened this issue May 10, 2024 · 1 comment · Fixed by #2831
Closed
10 tasks done

Refactor Os::Log into CMake Selection #2723

LeStarch opened this issue May 10, 2024 · 1 comment · Fixed by #2831
Assignees
@LeStarch
Labels
enhancement
Milestone
Release v3.5.0

Comments

@LeStarch
Copy link
Collaborator

LeStarch commented May 10, 2024 •
edited
Loading

F´ Version
Affected Component

Feature Description

  • Consider if Os::Log should be renamed Os::Console.
  • Refactor Os::Log into the Interface, Os::Log, and Implementation classes (following pattern of Os::File)
  • Implement Posix implementation
  • Implement Stub implementation
  • Implement Test stub implementation
  • Build common rules-based tests
  • Build specific posix tests
  • Build stub interface tests
  • Setup default posix implementation for Posix platforms
  • Document
@LeStarch LeStarch added this to the Release v3.5.0 milestone May 10, 2024
@LeStarch LeStarch mentioned this issue May 10, 2024
Open
19 tasks
@LeStarch LeStarch self-assigned this May 22, 2024
@LeStarch
Copy link
Collaborator Author

Note: tests too thin, no random testing needed.

@LeStarch LeStarch linked a pull request Aug 16, 2024 that will close this issue
Implements #2723: Adds Os::Console to replace Os::Log #2831
Merged
LeStarch added a commit that referenced this issue Aug 16, 2024
@LeStarch
Implements #2723: Adds Os::Console to replace Os::Log (#2831)
7159e7e 
* Initial logging refactor - WIP

* Removing LogAssert as it is not used

* Working on Fw::Logger rewrite

* Initial Os::Console refactor

* Fixing Fw::Logger unit tests

* Fixing up UT build

* Adding Os::Stub::Console implementation

* Added interface UTs

* Adding posix console tests

* Fixing Linux errors

* Spelling

* Initial review requests

* Fixing RPI build issues

* Fixing codeql errors

* Fixing code QL

* Validating 'message' parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeStarch LeStarch

Labels
enhancement
Projects
None yet
Milestone
Release v3.5.0
Development

Successfully merging a pull request may close this issue.

Implements #2723: Adds Os::Console to replace Os::Log LeStarch/fprime
1 participant
@LeStarch