Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2457 #2502

Merged
merged 44 commits into from
Feb 28, 2024
Merged

Issue 2457 #2502

merged 44 commits into from
Feb 28, 2024

Conversation

LeStarch
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Issue #2457

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
Os/Posix/File.cpp Fixed Show fixed Hide fixed
Os/Posix/errno.hpp Fixed Show fixed Hide fixed
Os/Stub/File.cpp Fixed Show fixed Hide fixed
Os/Stub/test/File.cpp Fixed Show fixed Hide fixed
Os/Stub/test/File.hpp Fixed Show fixed Hide fixed
Os/test/ut/file/MyRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/file/MyRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/file/MyRules.hpp Fixed Show fixed Hide fixed
Os/test/ut/file/SyntheticFileSystem.cpp Fixed Show fixed Hide fixed
Os/test/ut/file/SyntheticFileSystem.hpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
Os/File.cpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2024
View reviewed changes
Os/Stub/DefaultFile.cpp Fixed Show fixed Hide fixed
Os/Stub/test/DefaultFile.cpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 2, 2024
View reviewed changes
Os/File.cpp Fixed Show fixed Hide fixed
Os/File.cpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 6, 2024
View reviewed changes
Os/File.cpp Fixed Show fixed Hide fixed
Os/File.cpp Fixed Show fixed Hide fixed
Os/File.cpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 6, 2024
View reviewed changes
Os/Models/Models.hpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 6, 2024
View reviewed changes
Os/Posix/File.cpp Fixed Show fixed Hide fixed
Os/Stub/File.hpp Fixed Show fixed Hide fixed
@LeStarch
Copy link
Collaborator Author

@bocchino this should be ready for review. It appears the PI CI is offline again...but those have been passing.

bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/File.cpp Outdated Show resolved Hide resolved
bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/File.hpp Outdated Show resolved Hide resolved
bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/Models/File.fpp Outdated Show resolved Hide resolved
bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/Posix/File.cpp Outdated Show resolved Hide resolved
bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/Posix/File.cpp Outdated Show resolved Hide resolved
bocchino
bocchino reviewed Feb 14, 2024
View reviewed changes
Os/test/ut/OsTestMain.cpp Outdated Show resolved Hide resolved
timcanham
timcanham requested changes Feb 27, 2024
View reviewed changes
Fw/Types/Serializable.cpp Outdated Show resolved Hide resolved
Fw/Types/Serializable.cpp Show resolved Hide resolved
Fw/Types/Serializable.hpp Outdated Show resolved Hide resolved
bocchino
bocchino approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment.

timcanham
timcanham approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@timcanham timcanham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo Rob's most recent email concerning type names, but that can be done in another PR.

@bocchino
Copy link
Collaborator

bocchino commented Feb 28, 2024 •
edited
Loading

I think the type names agree with what we want (FwSizeStoreType). This looks good to me!

@LeStarch
Copy link
Collaborator Author

CI passed, hanging on artifact-uploade. I will merge now.

@LeStarch LeStarch merged commit 58c2141 into nasa:devel Feb 28, 2024
33 of 34 checks passed
@JohanBertrand JohanBertrand mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

@timcanham timcanham timcanham approved these changes

@bateller bateller bateller approved these changes

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeStarch @bocchino @bateller @timcanham @thomas-bc