Add JSON dictionary generation to CMake system #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch requires these changes to FPP: jwest115/fpp#1 |
thomas-bc
force-pushed
the
issue/2591-dict-autocode
branch
from
1b521f4
to
d18d8da
Compare
|
Rebased to catch latest devel, including fpp v2.1.0a7 with fpp-to-dict |
|
@LeStarch I finally managed to fix the bug on the RPI build by explicitly calling out the global This should be ready for review |
thomas-bc
commented
Apr 23, 2024
thomas-bc
commented
Apr 24, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@thomas-bc I bet this is because RPI does not use SystemResources and as such there is no dependence on |
LeStarch
reviewed
Apr 25, 2024
LeStarch
reviewed
Apr 25, 2024
LeStarch
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
There are several things of note:
- We need a plan for supporting sub-topologies. Not needed now, but someday.
- We should switch the CACHE variable used to hold the current dictionary to be a property of the module that creates it. I do not recommend doing this now, but when we tackle point 1.
- We need to move version.py at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Address #2591
Opening as draft to start get some feedback to improve upon