Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate fpp error messages. Fixes: #2618 #2620

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

LeStarch
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Cleans-up bad FPP installation errors:

  1. Missing Java now reports "missing java"
  2. Corrupt now recommends reinstall
  3. Missing recommends install

Rationale

Conflated error messages deconflated.

Testing/Review Recommendations

Tested the following:

  1. Removed fpp-depend: missing message reported
  2. Invalid binary fpp-fepend: invalid install reported, recommend reinstall
  3. Installed java wheel w/o Java: requires java reported

Future Work

Update install guide.

@LeStarch LeStarch requested a review from thomas-bc March 26, 2024 19:13
@thomas-bc
Copy link
Collaborator

Future Work: Update install guide.

What part needs changing?

@LeStarch
Copy link
Collaborator Author

LeStarch commented Mar 26, 2024

@thomas-bc see: #2621. It fixes the install guide.

@LeStarch LeStarch merged commit 55adfb5 into nasa:devel Mar 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants