Update JSON Dictionary spec #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
FPP annotations must be ASCII character strings. You could replace Schrödinger with Schroedinger. |
bocchino
reviewed
Apr 8, 2024
|
Agreed, fixed! |
|
Note to self: there's an issue with the rendering of some tables in the spec on the website: https://nasa.github.io/fprime/Design/fpp-json-dict.html This could be the solution: https://github.com/orgs/community/discussions/23945#discussioncomment-3242285 |
|
nvm: very likely has to do with whitespaces https://www.reddit.com/r/github/comments/15gexlw/comment/juik4y3 Fixed |
bocchino
reviewed
Apr 10, 2024
|
This state of the JSON dictionary spec is in sync with fpp-to-dict=2.1.0a7 (https://pypi.org/project/fprime-fpp-to-dict/2.1.0a7/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Type NametoType DescriptorEnumerated Constant DescriptorandStruct Member Descriptorfor sub-dictionaries that describe each conceptdescriptiontoannotationthroughout in the spec and added it where it was missingParameterssection after Events to respect the CTEP (Commands>Telemetry>Events>Parameter) orderRationale
Updating the spec with regards to feedback from inputting into the GDS / build system
Testing/Review Recommendations
Will be drastically easier to review with the "Display Rich Diff" option in the changed files
