Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trouble-shooting-guide-2500 #2684

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

rlcheng
Copy link
Collaborator

@rlcheng rlcheng commented Apr 17, 2024

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

A description of the changes contained in the PR.

Rationale

A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

 - Add troubleshooting.md.
   This is currently a copy of the troubleshooting section of
   https://nasa.github.io/fprime/INSTALL.html
@rlcheng rlcheng requested a review from LeStarch April 17, 2024 16:52
@LeStarch
Copy link
Collaborator

@rlcheng the one change I would ask for is to delete the "Troubleshooting" section from INSTALL and link to this one instead!

Something like: For users having issues, please consult our [trouble shooting guide](./troubleshooting.md). or whatever sounds best to you!

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request that you delete the copied section and link, other than that this is awesome!

 - Update INSTALL.md and remove troubleshooting guide and redirect
   to newly created separate file.
 - Remove empty line / space from troubleshooting.md.
@rlcheng
Copy link
Collaborator Author

rlcheng commented Apr 17, 2024

Request that you delete the copied section and link, other than that this is awesome!

Updates made. Old troubleshooting guide removed and link added. Tested and working.

@rlcheng rlcheng requested a review from LeStarch April 17, 2024 17:14
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LeStarch LeStarch merged commit 16a718a into nasa:devel Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants