-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI bash script for macOS #2742
Conversation
I am glad you remembered this! |
@LeStarch Is there anything else needed in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that link died and was removed in another PR. Thanks for making this change!
The RPI tests seem to be failing consistently though... 🤔 |
Interesting. Is there any link between this bash script and the RPI integration tests? Otherwise, are there any artefacts from previous jobs that could have been impacted? It used to pass without any problem in a previous PR: c98a070 |
It seems like the file descriptor stays at -1 during the test. I don't expect it to come from this bash script, and I don't think that's expected in the integration test?
From
|
This error means the RPIs need to be rebooted.....some orphaned process is holding onto the GPIO pins. They are supposed to reboot after each test, but this seems to be breaking. Regardless this PR can be merged. |
Change Description
Small change of the bash script to display errors happening on the CI. The bash version used on the Mac OS CI does not support negative values (See https://github.com/nasa/fprime/actions/runs/8902005968/job/24448082623 for the error, and https://github.com/nasa/fprime/actions/runs/8903107367/job/24450396620 for the fix)