Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI bash script for macOS #2742

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

JohanBertrand
Copy link
Contributor

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Small change of the bash script to display errors happening on the CI. The bash version used on the Mac OS CI does not support negative values (See https://github.com/nasa/fprime/actions/runs/8902005968/job/24448082623 for the error, and https://github.com/nasa/fprime/actions/runs/8903107367/job/24450396620 for the fix)

@LeStarch
Copy link
Collaborator

I am glad you remembered this!

@JohanBertrand
Copy link
Contributor Author

@LeStarch Is there anything else needed in this PR?
The CI did not pass, but I don't think it's because of the current changes

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that link died and was removed in another PR. Thanks for making this change!

@thomas-bc
Copy link
Collaborator

The RPI tests seem to be failing consistently though... 🤔

@JohanBertrand
Copy link
Contributor Author

JohanBertrand commented May 28, 2024

Interesting. Is there any link between this bash script and the RPI integration tests?

Otherwise, are there any artefacts from previous jobs that could have been impacted?

It used to pass without any problem in a previous PR: c98a070

@JohanBertrand
Copy link
Contributor Author

It seems like the file descriptor stays at -1 during the test. I don't expect it to come from this bash script, and I don't think that's expected in the integration test?

[GDS] Received EVR: 2024-05-28 13:18:20: fatalAdapter.AF_ASSERT_0 (16896) (2(0)-1716927500:896756) EventSeverity.FATAL : Assert in file /home/runner/work/fprime/fprime/fprime/Drv/LinuxGpioDriver/LinuxGpioDriverCompon, line 276

From Drv/LinuxGpioDriver/LinuxGpioDriverComponentImpl.cpp:

void LinuxGpioDriverComponentImpl ::
    gpioWrite_handler(
        const NATIVE_INT_TYPE portNum,
        const Fw::Logic& state
    )
  {
      FW_ASSERT(this->m_fd != -1);

      NATIVE_INT_TYPE stat;

      stat = gpio_set_value(this->m_fd,(state == Fw::Logic::HIGH) ? 1 : 0);

      if (0 != stat) {
          this->log_WARNING_HI_GP_WriteError(this->m_gpio,stat);
          return;
      }
  }

@LeStarch
Copy link
Collaborator

This error means the RPIs need to be rebooted.....some orphaned process is holding onto the GPIO pins. They are supposed to reboot after each test, but this seems to be breaking.

Regardless this PR can be merged.

@LeStarch LeStarch merged commit 49ab10d into nasa:devel May 28, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants