Add Events FPP interface #2749
Merged
Add Events FPP interface #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
reviewed
May 28, 2024
thomas-bc
changed the title
|
I added an interfaces section |
LeStarch
approved these changes
Jun 3, 2024
|
I corrected the merge conflict with the other interface PR we merged. |
thomas-bc
approved these changes
Jun 3, 2024
|
Thank you so much for helping me out in my first adventure in open source development. Is there anything else I should do? |
|
Nope! Welcome to the Open Source world, and thanks for completing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e set
Change Description
Created an Event Interface out of the standard event ports using #2255 as an example. There were only 2 event ports compared to 3 stated in the issue description.
Rationale
Part of #2578.
Testing/Review Recommendations
None
Future Work
Must work on the other interfaces.