-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise file name string sizes in AssertFatalAdapter events #2796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Rob, this looks great!
I added one comment about the sizing of the combuffer you may want to consider. I suspect we'll also want @LeStarch's signoff on this.
Also fix bug in CmdSplitterTester
For consitency with AMPCS compatibility code AMPCS arguments have max size 255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ready to merge?
Yes, ready! |
Change Description
This PR updates the sizes of the file name strings used in the AssertFatalAdapter events:
Rationale
On workstation development systems, e.g., Linux and Mac, an 80-character string is not long enough to report the location where an assertion has failed. For example, if an assertion failure occurs in an autocoded C++ file, the file name can have the following form:
That's 104 characters; with an 80-character string, the GDS displays the unimportant part (the path prefix that is common to all FSW files) and chops off the part you care about, which is at the end:
This behavior makes assertion failure event reports essentially unusable on these systems.
The assertion file strings that users get out of the box should satisfy two criteria:
The framework unit tests should also compile and run correctly under different configurations. I fixed the issues that I saw when making the configuration changes here. I'm sure there are more issues, which we won't see until we have a general way to test other configurations. This is a CI issue.