Update CI to use Json dictionaries #2806
Conversation
|
Looks good! I don't think this will pass yet, since we haven't done a release of the GDS with json dict support yet. @thomas-bc does it possibly make sense to do a alpha release of the GDS so that the core fprime repository can swap over and start testing against JSON dictionaries? |
|
@Joshua-Anderson yes, it does! |
|
@Lex-ari I did the alpha releases, committed the bump to your branch, de-conflicted another conflict, and CI is rerunning. Hopefully, this will resolve the issue. |
|
I think this also needs to be changed... Looking at the log, something is still expecting an XML header. I'm going to find it. |
There was a problem hiding this comment.
Yes, we haven't done a release and that's what's causing issues here. We have done an Alpha release but not a full one - the pip install doesn't catch the alpha release because the workflow has code pip install fprime-gds and not to install from requirements.txt
|
Fixed requirements. Will update CI GDS version. |
|
Note: breakages are blocking on tutorial PRs. Well get those merged tomorrow and rerun. |
|
@LeStarch I had to make a change to install |
Change Description
Updates CI to use Json dictionaries instead of XML dictionaries.
This essentially replaces
TopologyAppDictionary.xmltoTopologyDictionary.jsonin the RPi Test and fputil ci test.This also updates guides to use Json dictionaries.
Rationale
Updates since fprime-seqgen should use json dictionaries instead of xml for future versions of fprime.
Testing Recommendations
Ensure CI is still functional and correct and perhaps do additional testing on hardware.
cc @Joshua-Anderson @kevin-f-ortega