Fix random UT failures on PosixFile #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix UT failing FinalizeCrc test when crc calculation miss match. Miss match due to file crc and shadow being out of sync when both are not reinialized at the same time. * Update File::open in File.ccp to match shadow operation in FileRules.cpp to only reset crc when status is OP_OK. * Update FileRules.cpp to print out rule name during test. * Remove changing file mode in shadow_open() in FileRules.cpp to OPEN_NO_MODE when status is not OP_OK.
rlcheng
force-pushed
the
fix/random_ut_failure_posixfile
branch
from
2fbcb65
to
c6bcae4
Compare
* Fix additional issue where randomly generate file name may be too large for POSIX.
rlcheng
force-pushed
the
fix/random_ut_failure_posixfile
branch
from
c6bcae4
to
2e39bf6
Compare
thomas-bc
approved these changes
Sep 10, 2024
thomas-bc
changed the title
* Fix preallocate test from picking 0 for length, which causes unintentional error in preallocate cmd. * Fix seek() in SyntheticFileSystem and assert_file_seek() to allow for offset being 0.
LeStarch
reviewed
Sep 18, 2024
| @@ -497,7 +497,7 @@ void Os::Test::File::Tester::Preallocate::action( | |||
| state.assert_file_consistent(); | |||
| FileState original_file_state = state.current_file_state(); | |||
| FwSignedSizeType offset = static_cast<FwSignedSizeType>(STest::Pick::lowerUpper(0, FILE_DATA_MAXIMUM)); | |||
| FwSignedSizeType length = static_cast<FwSignedSizeType>(STest::Pick::lowerUpper(0, FILE_DATA_MAXIMUM)); | |||
| FwSignedSizeType length = static_cast<FwSignedSizeType>(STest::Pick::lowerUpper(1, FILE_DATA_MAXIMUM)); | |||
There was a problem hiding this comment.
@rlcheng do we have a test that proves that preallocate errors on a "0" size argument?
There was a problem hiding this comment.
We dont have one. Currently the SeekInvalidSize test randomly picks using the range original_file_state.position + 1, std::numeric+_limits. Seems to be always a positive non zero value that gets multiplied by -1. We can change the range to: 0, std::numeric_limits.
This should guarantee in a randomized test we can get a 0 or negative value.
There was a problem hiding this comment.
Let's track as a separate issue. Rather than randomizing, we should just add a specific test to the interface tests.
LeStarch
approved these changes
Sep 18, 2024
|
Merging despite known CI failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
A description of the changes contained in the PR.
Rationale
A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.
Testing/Review Recommendations
Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.
Future Work
Note any additional work that will be done relating to this issue.