Remove versions from SystemResources and updates to Version component #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at minimum events are sent
thomas-bc
reviewed
Sep 10, 2024
thomas-bc
changed the title
This was referenced Sep 12, 2024
Shivaly-Reddy
commented
Sep 12, 2024
| </packet> | ||
|
|
||
| <packet name="SystemRes3" id="7" level="2"> | ||
| <packet name="SystemRes3" id="6" level="2"> |
There was a problem hiding this comment.
Is it okay that I changed id for SystemRes3 from 7 to 6?
There was a problem hiding this comment.
As long as it is unique (which it is) it should not matter. We could also rename SystemRes3 to SystemRes2 since there is no SystemRes2 anymore, but not really needed
LeStarch
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This pull request is for ticket #2826 changes
Rationale
Testing/Review Recommendations
Updated UTs to ensure events are generated regardless of verbosity configuration but channel depend upon it.
Future Work
Currently there is no future work identified related to this issue.