Random UT Failure: PosixFile #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix UT failing FinalizeCrc test when crc calculation miss match. Miss match due to file crc and shadow being out of sync when both are not reinialized at the same time. * Update File::open in File.ccp to match shadow operation in FileRules.cpp to only reset crc when status is OP_OK. * Update FileRules.cpp to print out rule name during test. * Remove changing file mode in shadow_open() in FileRules.cpp to OPEN_NO_MODE when status is not OP_OK.
* Fix additional issue where randomly generate file name may be too large for POSIX.
* Fix preallocate test from picking 0 for length, which causes unintentional error in preallocate cmd. * Fix seek() in SyntheticFileSystem and assert_file_seek() to allow for offset being 0.
* Update get_test_filename() to exclude certain special characters and change minimum filename length to prevent posix open() from getting an unintentional bad file name.
|
@rlcheng do we need to limit to 2+ characters if we are removing specials? |
LeStarch
approved these changes
Oct 10, 2024
|
I am going to merge the fix anyway. |
|
We dont have to set it to 2+ but I did find it can be puzzling when you get a file name that is just ; which I did get. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Update get_test_filename() to exclude certain special characters and change minimum filename length to prevent posix open() from getting an unintentional bad file name.
Rationale
This fix removes possibility of creating a filename with single character . that causes unintentional error with posix open() in otherwise nominal tests (OpenForRead, OpenFileCreate, and OpenForWrite). Filenames are now 2 character minimum and cannot start with . or /, which can also cause problems.
Testing/Review Recommendations
Tested with seed values known to create the single char . filename: 522402, 588311, and 501569.
Future Work
None