Improved Linux GPIO Driver Using Chardev #2943
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| namespace Drv { | ||
|
|
||
|
|
||
| Os::File::Status errno_to_file_status(PlatformIntType errno_input) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| Drv::GpioStatus errno_to_gpio_status(PlatformIntType errno_input) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| U32 configuration_to_handler_flags(Drv::LinuxGpioDriver::GpioConfiguration configuration) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return flags; | ||
| } | ||
|
|
||
| U32 configuration_to_event_flags(Drv::LinuxGpioDriver::GpioConfiguration configuration) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| // Handler implementations for user-defined typed input ports | ||
| // ---------------------------------------------------------------------- | ||
|
|
||
| Os::File::Status LinuxGpioDriver ::setupLineHandle(const PlatformIntType chip_descriptor, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| Drv::GpioStatus LinuxGpioDriver ::gpioRead_handler(const NATIVE_INT_TYPE portNum, Fw::Logic& state) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| Drv::GpioStatus LinuxGpioDriver ::gpioWrite_handler(const NATIVE_INT_TYPE portNum, const Fw::Logic& state) { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| void LinuxGpioDriver ::pollLoop() { |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| // Construction, initialization, and destruction | ||
| // ---------------------------------------------------------------------- | ||
|
|
||
| LinuxGpioDriver ::LinuxGpioDriver(const char* const compName) : LinuxGpioDriverComponentBase(compName) {} |
Check notice
Code scanning / CodeQL
More than one statement per line Note
|
|
||
| LinuxGpioDriver ::LinuxGpioDriver(const char* const compName) : LinuxGpioDriverComponentBase(compName) {} | ||
|
|
||
| Drv::GpioStatus LinuxGpioDriver ::start(const FwSizeType priority, |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| return status; | ||
| } | ||
|
|
||
| Os::File::Status LinuxGpioDriver ::open(const char* device, |
Check notice
Code scanning / CodeQL
Function too long Note
LeStarch
added
the
Update Instructions Needed
* Fixing LedBlinker workshop for new GPIO driver * Fixing UT breakage --------- Co-authored-by: Michael D Starch <[email protected]>
Change Description