Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting shutdown/close usage; refactoring TcpServer #2950

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Correcting shutdown/close usage; refactoring TcpServer #2950

merged 4 commits into from
Oct 16, 2024

Conversation

LeStarch
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fixing shutdown/close behavior to allow for clean shutdown and port usage.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
Drv/Ip/SocketComponentHelper.cpp Fixed Show fixed Hide fixed
Drv/Ip/SocketComponentHelper.hpp Fixed Show fixed Hide fixed
Drv/TcpServer/TcpServerComponentImpl.cpp Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@LeStarch LeStarch mentioned this pull request Oct 15, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
Drv/Ip/IpSocket.cpp Dismissed Show dismissed Hide dismissed
Drv/Ip/IpSocket.cpp Dismissed Show dismissed Hide dismissed
Drv/Ip/IpSocket.hpp Fixed Show fixed Hide fixed
Drv/Ip/SocketComponentHelper.cpp Dismissed Show dismissed Hide dismissed
Drv/Ip/SocketComponentHelper.cpp Fixed Show fixed Hide fixed
Drv/Ip/TcpServerSocket.cpp Fixed Show fixed Hide fixed
Drv/Ip/TcpServerSocket.cpp Fixed Show fixed Hide fixed
Drv/Ip/TcpServerSocket.hpp Fixed Show fixed Hide fixed
Drv/Ip/UdpSocket.cpp Dismissed Show dismissed Hide dismissed
Drv/TcpServer/TcpServerComponentImpl.cpp Fixed Show fixed Hide fixed
LeStarch
LeStarch commented Oct 16, 2024
View reviewed changes
Drv/Ip/TcpServerSocket.cpp Outdated Show resolved Hide resolved
LeStarch
LeStarch commented Oct 16, 2024
View reviewed changes
Drv/Ip/TcpServerSocket.hpp Outdated Show resolved Hide resolved
LeStarch
LeStarch commented Oct 16, 2024
View reviewed changes
Drv/TcpServer/TcpServerComponentImpl.cpp Outdated Show resolved Hide resolved
Drv/Ip/test/ut/TestTcp.cpp Outdated Show resolved Hide resolved
Drv/Ip/test/ut/TestTcp.cpp Show resolved Hide resolved
Drv/TcpServer/test/ut/TcpServerTestMain.cpp Outdated Show resolved Hide resolved
Drv/TcpServer/test/ut/TcpServerTester.cpp Outdated Show resolved Hide resolved
Drv/TcpServer/test/ut/TcpServerTester.cpp Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2024
View reviewed changes
Drv/Ip/SocketComponentHelper.cpp Dismissed Show dismissed Hide dismissed
thomas-bc
thomas-bc approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed and confirmed the changes are in

@LeStarch LeStarch merged commit 9ed68fd into nasa:devel Oct 16, 2024
34 checks passed
This was referenced Oct 16, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeStarch @thomas-bc