-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ogma-core
: Reimplement DB parser using JSON Spec parser. Refs #122.
#124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Refs #122. Not all kinds of input files that use the JSON parsing library will provide all information. In some, information is implicit or simply not available, yet we should be able to deal with such files. This commit modifies the JSON spec parsing library so that some fields can be optional. In general, we assume we'll still have the essential fields (requirements, IDs, specs), but not all auxiliary information.
A prior commit has modified the JSON Spec parsing library to make some fields in input JSON files optional. This will make the library more versatile. This commit modifies the existing modules that use the JSON parsing library to use the new interface with optional types for some JSON Format spec fields. The extensional behavior of these modules does not change, compared to their behavior prior to the modification of the JSON Format Spec definition to make some fields optional.
The JSON parsing functions currently used by ogma-core to parse requirement DBs are very specific to the formats supported. This commit replaces the existing FRET DB parser and converter by one that is based on the new generic JSON-based parsing library. The old module implementing the ad hoc converter, as well as the dependency on the ad hoc parser, are removed.
The library ogma-language-fret-reqs is no longer needed, since its functions have been generalized in other libraries. Therefore, this library can be completely removed.
Change Manager: The function decode is imported but not really used in the code. It is necessary to review the implementation to minimize the introduction of technical debt (even if, extensionally, it works). |
ivanperez-keera
force-pushed
the
develop-json-db
branch
from
January 24, 2024 23:46
67ddfb9
to
a590ae6
Compare
Implementor: Fix implemented, review requested. |
Change Manager: Verified that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the ad hoc DB parser with a parser based on the generic JSON parser, as prescribed in the solution proposed for #122.