-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(html): minor fixes from validation #6962
Conversation
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/21/2023 04:27:00pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
4.29% (6)6 / 140 runsfailed over last 7 days |
15.71% (22)22 / 140 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 176 runsfailed over last 7 days |
52.27% (92)92 / 176 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6962 +/- ##
==========================================
- Coverage 48.66% 48.31% -0.35%
==========================================
Files 643 643
Lines 25719 25719
Branches 2512 2512
==========================================
- Hits 12517 12427 -90
- Misses 12699 12810 +111
+ Partials 503 482 -21
*This pull request uses carry forward flags. Click here to find out more. see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Two things:
- Let's link this to an issue. Either one in the backlog or let's create a new one describing the work (for traceability).
- The official title is "Open MCT" (2 words). I left a suggestion in the review.
Thanks for this! It should be good to merge once those two issues are addressed.
Co-authored-by: Jesse Mazzella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #6965
Describe your changes:
Fixes some html issues in the index.html file
All Submissions:
Author Checklist
Reviewer Checklist