Allow providing a path to --open-browser
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 26.87% 26.84% -0.04%
==========================================
Files 17 17
Lines 640 652 +12
==========================================
+ Hits 172 175 +3
- Misses 468 477 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you! Please add this to your post: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change
--open-browserto a SingleOrNoValue option type.Why
This allows users to give the starting path to be launched.
Closes #141
Testing
did lots of manual testing of combinations of CLI + .netconfig files to validate it opens the browser to the path given.