Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom entrypoint mapping env vars to cli args #1

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

nathan-az
Copy link
Owner

Cleaned up dockerfile, and parses environment variables with the SM_VLLM_ (sagemaker vllm) prefix to environment variables.

This is due to the fact that - as far as I know - vLLM does not support passing engine args as environment variables. TGI's flexibility is through using clap which allows args to be set either way (src).

Key changes:

  • New file - entrypoint for sagemaker with mapping, invoking same api server module
  • Slightly restructuring dockerfile to clean up requirements. Adds intermediate vllm-openai-base step with the additional pip requirements, which will be required for all openai-style servers. Derives from this for both the vllm-sagemaker image and vllm-base image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant