Update nimbus.clj #672
Merged
Update nimbus.clj #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding check to disallow topology submission if the topology name is blank. In one of the scenarios, we had pushed a topology with an empty name, and it showed up on the ui with only the uid. Also since it did not have any name we could not go into "Topology Details" to kill it, and hence had to clean up the state on the disk so that Nimbus kills the topology.
|
Looks fine but can you fix the formatting? That if statement should be aligned with the other if statement. |
Corrected formatting
|
Thanks Nathan!! Just updated the formatting. Ankit. |
|
One other thing – you don't need to wrap the error message in (str ...), as it's already a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check to disallow topology submission if the topology name is blank. In one of the scenarios, we had pushed a topology with an empty name, and it showed up on the ui with only the uid. Also since it did not have any name we could not go into "Topology Details" to kill it, and hence had to clean up the state on the disk so that Nimbus kills the topology.