[EXPERIMENTAL] Service framework #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
derekcollison
approved these changes
Oct 19, 2022
service.go
Outdated
| info := fmt.Sprintf("%s.INFO", subject) | ||
| svc.infoSub, err = nc.QueueSubscribe(info, QG, func(m *Msg) { | ||
| si := &ServiceInfo{ | ||
| Name: svc.name, |
There was a problem hiding this comment.
Should we have the subject you can send requests to here?
There was a problem hiding this comment.
it is part of the configuration for the service - part of the Endpoint struct - the reason for the indirection is that if when we support JetStream this will be a different kind of Endpoint.
There was a problem hiding this comment.
But I think an info request from a NATS cli or random app should get the subject back from this call as well.
There was a problem hiding this comment.
Ah! - that we can easily do that.
aricart
commented
Oct 20, 2022
service.go
Outdated
| Id string `json:"id"` | ||
| Description string `json:"description"` | ||
| Version string `json:"version"` | ||
| Subject string `json:"subject"` |
|
LGTM!
…On Thu, Oct 20, 2022 at 7:12 AM Alberto Ricart ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In service.go
<#1111 (comment)>:
> + NumRequests int `json:"numRequests"`
+ NumErrors int `json:"numErrors"`
+ TotalLatency time.Duration `json:"totalLatency"`
+ Data interface{} `json:"data"`
+}
+
+// We can fix this, as versions will be on separate subjects and use account mapping to roll requests to new versions etc.
+const QG = "svc"
+
+// ServiceInfo is the basic information about a service type
+type ServiceInfo struct {
+ Name string `json:"name"`
+ Id string `json:"id"`
+ Description string `json:"description"`
+ Version string `json:"version"`
+ Subject string `json:"subject"`
fixed!
—
Reply to this email directly, view it on GitHub
<#1111 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAV74MUXYJGW2WSGEF2UHTWEFHOTANCNFSM6AAAAAARJRYOFU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
piotrpio
force-pushed
the
alberto-services
branch
5 times, most recently
from
73b1a1f to
8f9a687
Compare
piotrpio
force-pushed
the
alberto-services
branch
from
8f9a687 to
a49531e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a wip for the go version - need to do another pass
The javascript one can be found here nats-io/nats.deno#383