Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server urls connection management #648

Merged
merged 10 commits into from
Jun 1, 2022
Merged

Server urls connection management #648

merged 10 commits into from
Jun 1, 2022

Conversation

scottf
Copy link
Contributor

@scottf scottf commented May 25, 2022 •
edited
Loading

  1. architecture issue 113 Add option to ignore discovered urls
  2. ServersToTryProvider provide a way that a user can provide a complete custom implementation and provide the server urls to try on connect / reconnect. Tiered servers could be implemented this way.

@scottf
1. issue 113 Add option to ignore discovered urls
718dd7b 
2. ServersToTryProvider provide a way that a user can provide the server urls to try on connect / reconnect. This supports eventual tiered server bootstrap.
aricart
aricart approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - for changes like this, it would be great if there were two prs, one to handle the ignores and another to add the new feature.

@scottf scottf merged commit 8ff84be into main Jun 1, 2022
@scottf scottf deleted the server-connection-management branch June 1, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

@ColinSullivan1 ColinSullivan1 Awaiting requested review from ColinSullivan1

@tbeets tbeets Awaiting requested review from tbeets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @aricart