Merge pull request #338 from nats-io/no_panic_on_unmarshal_error

[FIXED] No panic on protobuf Unmarshal errors
nats-io · Jan 8, 2021 · 299fe0f · 299fe0f
2 parents 22aa6ac + a4f322d
commit 299fe0f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/pb/protocol.pb.go b/pb/protocol.pb.go
diff --git a/stan.go b/stan.go
@@ -700,7 +700,8 @@ func (sc *conn) processAck(m *nats.Msg) {
 	pa := &pb.PubAck{}
 	err := pa.Unmarshal(m.Data)
 	if err != nil {
-		panic(fmt.Errorf("error during ack unmarshal: %v", err))
+		fmt.Printf("error during ack unmarshal: %v\n", err)
+		return
 	}
 
 	// Remove
@@ -846,7 +847,8 @@ func (sc *conn) processMsg(raw *nats.Msg) {
 	msg := &Msg{}
 	err := msg.Unmarshal(raw.Data)
 	if err != nil {
-		panic(fmt.Errorf("error processing unmarshal for msg: %v", err))
+		fmt.Printf("error during message unmarshal: %v\n", err)
+		return
 	}
 	var sub *subscription
 	// Lookup the subscription