Feature: Prototype Ergo-base dockerfile #99
Conversation
| if [ -f "requirements.txt" ]; then | ||
| echo "installing via requirements.txt" | ||
| # if using requirements.txt, might be recommended to use ssh installation | ||
| python3 -m pip install -r requirements.txt | ||
| elif [ -f "setup.py" ]; then | ||
| echo "installing via setup.py" | ||
| pip install . | ||
| pip install -e ../../lib | ||
| elif [ -f "Pipfile" ]; then | ||
| echo "installing via pipenv" | ||
| export PYPI_PASSWORD=$(cat /run/secrets/PYPI_PASSWORD) | ||
| pipenv install |
There was a problem hiding this comment.
Could probably scrap these
There was a problem hiding this comment.
i agree! our logic is much simpler if we remove installing via requirements.txt, via setup.py, etc and just consolidate on peotry. Thinking of opening up a similar PR for ergo-infra
|
|
||
| if [ ! -f ${NAMESPACES}/${NAMESPACE} ] | ||
| then | ||
| echo "Namespace ${NAMESPACES}/${NAMESPACE} does not exist - dynamically generating..." |
There was a problem hiding this comment.
This is v nice! When do we need these dynamic configs?
There was a problem hiding this comment.
oooo do like echos for more usability!
any reason for not updating the error messages in the ergo codebase itself to be more descriptive / helpful?
| RUN mkdir ${BASE}/namespaces | ||
|
|
||
| # hardcoded for root user | ||
| ENV PATH="/root/.local/bin:${PATH}:/root/.poetry/bin" |
There was a problem hiding this comment.
the .poetry directory won't exist without a valid poetry installation step
| # syntax = docker/dockerfile:1.0-experimental | ||
| FROM python:3.9-slim as ergo_base | ||
| ARG comp | ||
| ARG qed_dir="." |
There was a problem hiding this comment.
this might be a little overly specific to qed
| @@ -0,0 +1,40 @@ | |||
| all: clean build | |||
| synch: | |||
There was a problem hiding this comment.
nit sorry
| synch: | |
| sync: |
| elif [ -f "pyproject.toml" ]; then | ||
| echo "installing via poetry" | ||
| export POETRY_HTTP_BASIC_NAUTILUS_USERNAME=$(cat /run/secrets/POETRY_HTTP_BASIC_NAUTILUS_USERNAME) | ||
| export POETRY_HTTP_BASIC_NAUTILUS_PASSWORD=$(cat /run/secrets/POETRY_HTTP_BASIC_NAUTILUS_PASSWORD) |
There was a problem hiding this comment.
there's no need to keep both secrets
| export POETRY_HTTP_BASIC_NAUTILUS_PASSWORD=$(cat /run/secrets/POETRY_HTTP_BASIC_NAUTILUS_PASSWORD) | |
| export POETRY_HTTP_BASIC_NAUTILUS_PASSWORD=$(cat /run/secrets/PYPI_PASSWORD) |
| pipenv install | ||
| elif [ -f "pyproject.toml" ]; then | ||
| echo "installing via poetry" | ||
| export POETRY_HTTP_BASIC_NAUTILUS_USERNAME=$(cat /run/secrets/POETRY_HTTP_BASIC_NAUTILUS_USERNAME) |
There was a problem hiding this comment.
isn't it enough for the password to be secret?
| export POETRY_HTTP_BASIC_NAUTILUS_USERNAME=$(cat /run/secrets/POETRY_HTTP_BASIC_NAUTILUS_USERNAME) | |
| export POETRY_HTTP_BASIC_NAUTILUS_USERNAME=nautiluslabs |
Prototype docker file for creating proposed ergo-base image for ergo components.