This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ipfabric into develop � Conflicts: � pyproject.toml
Fixes for interfaces load
…hatops-ipfabric into develop � Conflicts: � poetry.lock
v5.0 Changes
Remove loaded snapshot table from set_snapshot prompt
chadell
reviewed
Sep 22, 2022
As part of this PR you could pass the "timeout" kwarg to the IP Fabric API, currently it's not passed. The two sections below need to be updated |
@pauljorgenson Please update to ipfabric==5.0.11 |
@justinjeffery-ipf are you wanting the dependency pinned or update in the code referenced? |
Pinned to minimum of latest |
whitej6
approved these changes
Sep 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change - only support IP Fabric version v5+