Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Release v2.0.0 #115

Merged
merged 18 commits into from
Sep 24, 2022
Merged

Release v2.0.0 #115

merged 18 commits into from
Sep 24, 2022

Conversation

pke11y
Copy link
Contributor

@pke11y pke11y commented Sep 22, 2022

Breaking change - only support IP Fabric version v5+

CHANGELOG.md Outdated Show resolved Hide resolved
@pauljorgenson
Copy link

@ghost
Copy link

ghost commented Sep 22, 2022

As part of this PR you could pass the "timeout" kwarg to the IP Fabric API, currently it's not passed. The two sections below need to be updated

https://github.com/nautobot/nautobot-plugin-chatops-ipfabric/blob/release-v2.0.0/nautobot_chatops_ipfabric/ipfabric_wrapper.py#L100-L104

https://github.com/nautobot/nautobot-plugin-chatops-ipfabric/blob/release-v2.0.0/nautobot_chatops_ipfabric/worker.py#L37-L42

@pauljorgenson Please update to ipfabric==5.0.11

@pke11y pke11y requested a review from chadell September 22, 2022 14:25
@whitej6
Copy link
Contributor

whitej6 commented Sep 23, 2022

@justinjeffery-ipf are you wanting the dependency pinned or update in the code referenced?

@pke11y
Copy link
Contributor Author

pke11y commented Sep 23, 2022

@justinjeffery-ipf are you wanting the dependency pinned or update in the code referenced?

Pinned to minimum of latest ipfabric

Copy link
Contributor

@whitej6 whitej6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pke11y pke11y merged commit c6d3a15 into main Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants