Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs #1095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo in docs #1095

wants to merge 2 commits into from

Conversation

mojh7
Copy link

@mojh7 mojh7 commented Nov 19, 2024

Summary

v1.0.x 공식 문서의 Jakarta Validation 플러그인 관련 글에서 예시대로 Gradle 의존성 설정하다가 artifact id 오타를 발견했습니다.

  • jakarta-validationfixture-monkey-jakarta-validation

다른 버전 문서도 확인했는데 v0.6.x는 문제 없고 v1.0.xv1.1.x 영문, 한글 문서에서 동일한 오타를 발견해서 4개의 파일을 수정했습니다.

Modify gradle dependency artifactId 'jakarta-validation' to 'fixture-monkey-jakarta-validation'
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@@ -15,7 +15,7 @@ Fixture Monkey는 Fixture Monkey Jakarta Validation 플러그인을 사용하여
### Dependencies
#### Gradle
```
testImplementation("com.navercorp.fixturemonkey:jakarta-validation:1.0.0")
testImplementation("com.navercorp.fixturemonkey:fixture-monkey-jakarta-validation:1.0.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0{{< fixture-monkey-version >}} 로 수정해주실 수 있을까요??

Comment on lines 18 to 19
testImplementation("com.navercorp.fixturemonkey:fixture-monkey-jakarta-validation:1.0.0")
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 {{< fixture-monkey-version >}}로 수정되면 좋을 것 같습니다.

@mojh7
Copy link
Author

mojh7 commented Nov 20, 2024

@seongahjov1.0.x-kor, v1.1.x-kor 문서 내용 수정했습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants