Auto set the Y axis label width #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademille
commented
Dec 15, 2023
| @@ -43,6 +42,7 @@ type brailleCell struct { | |||
| type Plot struct { | |||
| *tview.Box | |||
| data [][]float64 | |||
| maxVal float64 | |||
There was a problem hiding this comment.
The max data value was calculated in several places. And I would have had to calculated it again for this change. So, I figured it was better to do it once when the data was set.
ademille
force-pushed
the
main
branch
2 times, most recently
from
d06fc2f to
af27ccd
Compare
ademille
commented
Dec 15, 2023
| @@ -1,6 +1,6 @@ | |||
| # Contributing To Tvxwidgets | |||
|
|
|||
| We'd love your contribtion on the project! | |||
There was a problem hiding this comment.
The spell check was failing, so I fixed this as well.
|
Max value is over 18000. After the change: |
The Y axis label width was hard coded to 4 with 2 decimal places. This caused any number larger than 1000 to be truncated. The Y axis label width is now based on the maximum value in the data set, allowing enough characters for the whole number along with 2 decimal places. Signed-off-by: Aaron DeMille <[email protected]>
|
@ademille thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Y axis label width was hard coded to 4 with 2 decimal places. This caused any number larger than 1000 to be truncated.
The Y axis label width is now based on the maximum value in the data set, allowing enough characters for the whole number along with 2 decimal places.