Reward adjustments fixes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarinkovic
force-pushed
the
reward_adjustments
branch
4 times, most recently
from
a604c08 to
afb1ada
Compare
Merged
amarinkovic
force-pushed
the
reward_adjustments
branch
from
309563f to
ffe121c
Compare
amarinkovic
commented
Jun 10, 2024
Comment on lines
+155
to
+156
| uint256 boost1 = ((((_getD(_entityId) - ratio) * _amount) / _getD(_entityId)) * _getA(_entityId)) / _getD(_entityId); | ||
| uint256 boost2 = (((ratio * _amount) / _getD(_entityId)) * _getA(_entityId)) / _getD(_entityId); | ||
| uint256 balance1 = _amount - (ratio * _amount) / _getD(_entityId); | ||
| uint256 balance2 = (ratio * _amount) / _getD(_entityId); |
chore: fresh new deploy to testnets chore: update testnet fork addresses chore: bump version to 3.8.10
test: fix test_threeStakersAndRewardsIntertwine with dynamic reward and balance assertions fix: staking amounts before init
…rt time in stake()
amarinkovic
force-pushed
the
reward_adjustments
branch
from
fff4800 to
49c95f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staking or unstaking of any user should have no effect on other user's rewards and boosts. Basic test case that is addressed with this change set, is described in
test_threeStakersAndRewardsIntertwine.