Code

Adherence to Best Practices#62

Code

Merged

amarinkovic merged 15 commits intoaudit-fixesnayms/contracts-v3:audit-fixesfrom best_practicesnayms/contracts-v3:best_practicesCopy head branch name to clipboardApr 28, 2023

+118-155

Commits

Commits on Apr 28, 2023

• fix: unused imports, typos and redundant code

  amarinkovic

  committed
  0559b11

• fix: commission arrays length limit

  amarinkovic

  committed
  1840069

• fix: index address in events

  amarinkovic

  committed
  c1aa975

• fix: reuse variables

  amarinkovic

  committed
  7b83b48

• fix: remove redundant struct

  amarinkovic

  committed
  aa6efa4

• chore: remove LibMeta.sol

  

  kevin-fruitful

  authored and

  amarinkovic

  committed
  3456c69

• refactor: LibDiamond.initializeDiamondCut() throws error InitializationFunctionReverted instead of require msg

  

  kevin-fruitful

  authored and

  amarinkovic

  committed
  40c5368

• docs: remove todo comments in code

  

  kevin-fruitful

  authored and

  amarinkovic

  committed
  01cad59

• docs: improve explanation of UserFacet

  

  kevin-fruitful

  authored and

  amarinkovic

  committed
  3ee1cdb

• doc: fix some missing natspec comments

  amarinkovic

  committed
  11e9f79

• doc: fix some typos

  amarinkovic

  committed
  ec7b664

• fix: rename role updated event

  amarinkovic

  committed
  e77350c

• doc: clarify premium commission basis points

  

  kevin-fruitful

  authored and

  amarinkovic

  committed
  039b861

• fix: comment typos

  amarinkovic

  committed
  9768ef5

• fix: policy event test

  amarinkovic

  committed
  49f4369